Use EPP instead of ERB for some templates #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jun 24, 2021
|
I decided to push #964 which is what I meant. I also left a comment where I think we should unwrap it. |
|
I've merged #964 so would you mind rebasing to resolve the conflict? |
- As a Preparation for making this Module "Sensitive"-aware, we prefer to use EPP instead of ERB in such Situations, where "Sensitive" could come into Play, as EPP is able to handle Data of Type Sensitive natively.
Done. |
ekohl
approved these changes
Jul 6, 2021
|
And those tests are green. Thanks! |
ekohl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a Preparation for making this Module "Sensitive"-aware, we prefer to
use EPP instead of ERB in such Situations, where "Sensitive" could come
into Play, as EPP is able to handle Data of Type Sensitive natively.