-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to puppet/systemd #997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update the puppet/redis dependency to >= 8.0.0
for voxpupuli/puppet-redis@e439cd0#diff-12e598daecade60b04e493f45c134fec9287ac7471114d95d1995b4fb651a6c8.
We should also coordinate all modules so we don't break nightly so I'd prefer to have PRs for all modules.
This is also needs an update: Lines 16 to 18 in d84fb8e
|
|
66f7b10
to
5e82e18
Compare
0903211
to
5737a8d
Compare
Like what I did now? |
Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
5737a8d
to
4e5bd93
Compare
2 tests fail (both on CentOS 8); the error is weird, which makes me believe it is unrelated to the PR. Is there a way to rerun a single test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 tests fail (both on CentOS 8); the error is weird, which makes me believe it is unrelated to the PR.
I think so too
Is there a way to rerun a single test?
No, there isn't. I'm fine with merging this PR with those tests as red. I'm just going to make sure that all our PRs are ready to be merged before pressing the big green button.
No description provided.