correctly set serveraliases for the reverse proxy

the correct parameter to `apache::vhost` is `serveraliases`, not `aliases`. the later is for folder aliases and has totally different syntax. Fixes: 2f9ada4
theforeman · Jun 15, 2022 · bbb8ac5 · bbb8ac5
1 parent f355747
commit bbb8ac5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/manifests/reverse_proxy.pp b/manifests/reverse_proxy.pp
@@ -37,7 +37,7 @@
   apache::vhost { $vhost_name:
     ensure                 => $ensure,
     servername             => $certs::apache::hostname,
-    aliases                => $certs::apache::cname,
+    serveraliases          => $certs::apache::cname,
     port                   => $port,
     docroot                => '/var/www/',
     priority               => $priority,

diff --git a/spec/defines/foreman_proxy_content__reverse_proxy_spec.rb b/spec/defines/foreman_proxy_content__reverse_proxy_spec.rb
@@ -18,7 +18,7 @@
         it do
           is_expected.to contain_apache__vhost('my-reverse-proxy')
             .with_servername(facts[:fqdn])
-            .with_aliases([])
+            .with_serveraliases([])
             .with_port(8443)
             .with_proxy_pass([{
               'path' => '/',
@@ -37,7 +37,7 @@
         it do
           is_expected.to contain_apache__vhost('katello-reverse-proxy-443')
             .with_servername('foo.example.com')
-            .with_aliases([])
+            .with_serveraliases([])
             .with_port(443)
             .without_keepalive # Not part of the vhost but used in the vhost_params
             .with_proxy_pass([{
@@ -65,7 +65,7 @@ class { 'certs::apache':
           it do
             is_expected.to contain_apache__vhost('katello-reverse-proxy')
               .with_servername('proxy.example.com')
-              .with_aliases(['proxy-01.example.com'])
+              .with_serveraliases(['proxy-01.example.com'])
           end
         end