refs #17366 - rename to puppet-foreman_proxy_content #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we reset the versioning since its a rename? |
|
Sure, that works. I think we could really do anything, I was originally thinking to call it 5.0. But do you have any preference? 1.0? 0.1? 0.0.1? |
stbenjam
force-pushed
the
17366
branch
3 times, most recently
from
f2e2588 to
c1af40b
Compare
stbenjam
changed the title
|
I'm good with 1.0 unless you feel it should go through a bit of non-semantic versioning before saying its "1.0" worthy. |
ehelms
approved these changes
Dec 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.