Refs #16253 - Add max speed var to foreman-proxy-content #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean797
force-pushed
the
max_speed
branch
4 times, most recently
from
9563d35 to
15fc5d4
Compare
stbenjam
reviewed
Jan 26, 2017
manifests/init.pp
Outdated
| @@ -33,6 +33,9 @@ | |||
| # $pulp_oauth_secret:: OAuth secret to be used for Pulp REST interaction | |||
| # type:Optional[String] | |||
| # | |||
| # $pulp_max_speed:: The maximum download speed for a Pulp task per second. (e.g. "4 Kb" or 1Gb") | |||
| # type:string | |||
There was a problem hiding this comment.
We moved over to Puppet 4 types, can you change this to be type:Optional[String]?
sean797
force-pushed
the
max_speed
branch
3 times, most recently
from
c5320de to
f2e3696
Compare
|
Not sure why tests are failing, seem unrelated to me? |
|
It's puppet-lint: There's a bug in the latest version where it's not rendering the messages. I think it's mostly you have trailing whitespace on some of your lines that needs to be removed. |
|
\o/ thanks @stbenjam 👍 |
|
Submitted Katello/foreman-installer-modulesync#16 to fix the puppet-lint issue. |
ekohl
approved these changes
Feb 3, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.