introduce rhsm_hostname parameter #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Oct 27, 2017
| # $rhsm_url:: The URL that the RHSM API is rooted at | ||
| # $rhsm_hostname:: The hostname that the RHSM API is rooted at | ||
| # | ||
| # $rhsm_url:: The URL path that the RHSM API is rooted at |
There was a problem hiding this comment.
Looks like this parameter is badly named. 👍 for at least improving the documentation.
There was a problem hiding this comment.
Yeah, the parameter name is very misleading. rhsm_path or something would be better.
ekohl
approved these changes
Nov 24, 2017
sean797
approved these changes
Nov 28, 2017
There was a problem hiding this comment.
Nice, this will be needed when we get that multi homing PR in core. Thanks @timogoebel 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter
rhsm_hostnamethat allows overwriting the hostname that is configured into the client cert rpm.