Allow use of puppet-qpid 4.X #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
approved these changes
Jan 25, 2018
ekohl
requested changes
Jan 25, 2018
metadata.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| }, | |||
| { | |||
| "name": "katello-qpid", | |||
| "version_requirement": ">= 3.0.0 < 4.0.0" | |||
| "version_requirement": ">= 3.0.0 < 5.0.0" | |||
There was a problem hiding this comment.
It will actually not work with < 4.0 versions
ehelms
force-pushed
the
puppet-qpid-4.0
branch
from
b62abd3 to
d54870f
Compare
|
Good catch -- updated |
|
theforeman/puppet-foreman_proxy#407 will release 7.0 and would break metadata again. Mind including that too? :) |
ehelms
force-pushed
the
puppet-qpid-4.0
branch
from
d54870f to
c598b67
Compare
ekohl
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.