make all repo types configurable #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlsherrill
force-pushed
the
config_types
branch
from
02a9010 to
738414f
Compare
sean797
suggested changes
Feb 26, 2018
manifests/init.pp
Outdated
| enable_ostree => $enable_ostree, | ||
| enable_rpm => $enable_yum or $enable_file, |
There was a problem hiding this comment.
shouldn't there be enable_iso => $enable_file ?
It was added recently ;) theforeman/puppet-pulp@1faa3e7
There was a problem hiding this comment.
I think your also need to update the minimum version in metadata.json
There was a problem hiding this comment.
ahhhh, didn't realize this was a thing now. @sean797 It doesn't look like that actually would work on its own without enabling yum (since the yum plugin wouldn't be installed, or am i misreading something?)
There was a problem hiding this comment.
Ah yes, I think you're right :( theforeman/puppet-pulp#309 😉
jlsherrill
force-pushed
the
config_types
branch
2 times, most recently
from
744ddad to
53782f9
Compare
ekohl
requested changes
Feb 27, 2018
jlsherrill
force-pushed
the
config_types
branch
from
53782f9 to
6dbdad0
Compare
|
ahhh right, updated! |
ekohl
approved these changes
Feb 27, 2018
|
@sean797 look good now? |
sean797
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.