-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #28711 - Serve /pulp/content over http with pulp3 #231
Conversation
I think looking at this it'd be worth splitting https://github.com/theforeman/puppet-foreman_proxy_content/blob/master/templates/pulpcore-apache.conf.erb into two pieces. One fragment for the Content app and one for the API app. Then you can create fragments for each and re-use the definitions of the Content app for http and https. |
This approach seems much cleaner. Will test it. |
80bed7c
to
eabf9d4
Compare
23dcab1
to
7a2b36e
Compare
Nit on the commit message: the short summary should say what it does, not what it doesn't do. https://chris.beams.io/posts/git-commit/#imperative has a great description and also examples. |
Noted. I simply copied the title of the Redmine but since it's linked by the issue # already I'll instead reword it to be more useful. |
Adds http support for /pulp/content using foreman::config::apache::fragment.
7a2b36e
to
fac8e9b
Compare
Adds http support for /pulp/content using foreman::config::apache::fragment