Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28711 - Serve /pulp/content over http with pulp3 #231

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Jan 16, 2020

Adds http support for /pulp/content using foreman::config::apache::fragment

@ehelms
Copy link
Member

ehelms commented Jan 17, 2020

I think looking at this it'd be worth splitting https://github.com/theforeman/puppet-foreman_proxy_content/blob/master/templates/pulpcore-apache.conf.erb into two pieces. One fragment for the Content app and one for the API app. Then you can create fragments for each and re-use the definitions of the Content app for http and https.

@wbclark
Copy link
Contributor Author

wbclark commented Jan 17, 2020

I think looking at this it'd be worth splitting https://github.com/theforeman/puppet-foreman_proxy_content/blob/master/templates/pulpcore-apache.conf.erb into two pieces. One fragment for the Content app and one for the API app. Then you can create fragments for each and re-use the definitions of the Content app for http and https.

This approach seems much cleaner. Will test it.

@wbclark wbclark force-pushed the pulpcore_http_content branch 4 times, most recently from 80bed7c to eabf9d4 Compare January 17, 2020 17:30
@wbclark wbclark force-pushed the pulpcore_http_content branch 4 times, most recently from 23dcab1 to 7a2b36e Compare January 17, 2020 18:50
@ekohl
Copy link
Member

ekohl commented Jan 17, 2020

Nit on the commit message: the short summary should say what it does, not what it doesn't do. https://chris.beams.io/posts/git-commit/#imperative has a great description and also examples.

@wbclark
Copy link
Contributor Author

wbclark commented Jan 17, 2020

Nit on the commit message: she short summary should say what it does, not what it doesn't do. https://chris.beams.io/posts/git-commit/#imperative has a great description and also examples.

Noted. I simply copied the title of the Redmine but since it's linked by the issue # already I'll instead reword it to be more useful.

Adds http support for /pulp/content using foreman::config::apache::fragment.
@wbclark wbclark force-pushed the pulpcore_http_content branch from 7a2b36e to fac8e9b Compare January 17, 2020 19:08
@ehelms ehelms merged commit 132d38f into theforeman:master Jan 17, 2020
@ekohl ekohl changed the title Fixes #28711 - /pulp/content is not being served over http with pulp3 Fixes #28711 - Serve /pulp/content over http with pulp3 Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants