Pass https_ca_cert to pulp #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
411e6ad stopped passing in ca_cert. When https_ca_cert is not passed to pulp, it falls back to ca_cert. This now makes sure Apache serves the correct CA certificate matching the server certificate and the correct certificate for client cert authentication. It also starts to pass https_chain. This should make sure that the correct CA is presented when using custom certificates while still allowing CA authentication using the default CA.
ekohl
force-pushed
the
pass-pulp-ca-cert
branch
from
bb6cf47 to
b9e693a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
411e6ad stopped passing in
ca_cert. Whenhttps_ca_certis not passed in to pulp, it falls back toca_cert. This now makes sure Apache serves the correct CA certificate matching the server certificate and the correct certificate for client cert authentication.It also starts to pass
https_ca_chain. This should make sure that the correct CA is presented when using custom certificates while still allowing CA authentication using the default CA.