Refs #30023: Enable Pulpcore RPM plugin #261
Conversation
| @@ -363,6 +366,7 @@ | |||
|
|
|||
| include pulpcore::plugin::container | |||
| include pulpcore::plugin::file | |||
| include pulpcore::plugin::rpm | |||
There was a problem hiding this comment.
general question: shouldn't those plugin includes (at least file and rpm) be inside the respective "proxy to pulpcore" blocks? as otherwise we'd be installing the pulpcore plugin but not using it, which seems like a waste?
There was a problem hiding this comment.
The idea is that the plugin is installed. This allows you to migrate content from Pulp 2. Also the Pulp 3 content URLs are always available. The "proxy to pulpcore" blocks are about routing the old Pulp 2 URLs to Pulp 3 so clients don't have to be modified. Ideally they should, but this allows to do so at a convenient pace.
| @@ -287,7 +290,7 @@ | |||
|
|
|||
| class { 'pulp': | |||
| enable_ostree => $enable_ostree, | |||
| enable_rpm => $enable_yum, | |||
| enable_rpm => $enable_yum and !$proxy_pulp_yum_to_pulpcore, | |||
There was a problem hiding this comment.
Not really for this PR, but this made me think of it: we don't have conditional to disable crane if we proxy container content to Pulpcore.
There was a problem hiding this comment.
Yea, I think we just were leaning towards leave Crane alone till we can safely rip it out.
No description provided.