Refs #30363: Generate new bootstrap RPM if old style is detected #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Aug 31, 2020
ekohl
reviewed
Aug 31, 2020
Prior implementation of bootstrap RPM created a tarball with the source script in it. If an RPM is detected with a tarball source, assume this is an upgrade and generate a new bootstrap RPM to be based on the new system from this point forward. This if condition can then be dropped in the next release.
ekohl
approved these changes
Aug 31, 2020
|
I didn't test it, but LGTM. Feel free to merge when Travis is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior implementation of bootstrap RPM created a tarball with
the source script in it. If an RPM is detected with a tarball
source, assume this is an upgrade and generate a new bootstrap
RPM to be based on the new system from this point forward.
This if condition can then be dropped in the next release.