Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing variable scoping on reverse_proxy and add tests for pulpcore #294

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix missing variable scoping on reverse_proxy and add tests for pulpcore #294

merged 1 commit into from
Nov 16, 2020

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Nov 16, 2020

No description provided.

wbclark
wbclark reviewed Nov 16, 2020
View reviewed changes
Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a Redmine to link this to the previous PR, but the previous PR didn't have one. In that case how about referencing the previous commit in the commit message here?

@ehelms
Copy link
Member Author

ehelms commented Nov 16, 2020

I would suggest a Redmine to link this to the previous PR, but the previous PR didn't have one. In that case how about referencing the previous commit in the commit message here?

Done. You can see it in the commit message.

@wbclark wbclark merged commit 46f90bc into theforeman:master Nov 16, 2020
@wbclark wbclark added the Bug label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbclark wbclark wbclark approved these changes

Assignees
No one assigned
Labels
Bug Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @wbclark @theforeman-bot