Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy_pulp_deb_to_pulpcore parameter #296

Closed
wants to merge 1 commit into from
Closed

Add proxy_pulp_deb_to_pulpcore parameter #296

wants to merge 1 commit into from

Conversation

m-bucher
Copy link

Enable proxying of pulp_deb for pulpcore.
Dependent code in theforeman/puppet-pulpcore was implemented by @jlsherrill and already merged in theforeman/puppet-pulpcore#145

@jlsherrill
Copy link
Contributor

is this a duplicate of #292 ?

wbclark
wbclark reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @m-bucher , thanks for the PR! This one looks like a duplicate of #292 . Let me know if it's OK to close this and feel free to share any feedback on the other one. I'll take a look today and try to keep it moving forward.

@m-bucher
Copy link
Author

@jlsherrill indeed it is 😊
closing in favour of #292

Note to self: use search-function 😆

@m-bucher m-bucher closed this Nov 17, 2020
@m-bucher m-bucher deleted the add_proxy_pulp_deb_to_pulpcore branch November 17, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbclark wbclark wbclark left review comments

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-bucher @jlsherrill @wbclark @theforeman-bot