Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move static defaults from params to init #298

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Move static defaults from params to init #298

merged 2 commits into from
Dec 2, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 20, 2020

This makes init easier to read and reduces the risk of forgetting a default.

It also removes unused defaults that we failed to remove.

ekohl added 2 commits November 20, 2020 15:29
@ekohl
Remove unused default variables
00867cb 
f674725 removed the certs_tar parameter
but left the default.

7bf101d did the same thing for
rhsm_hostname and rhsm_url.
@ekohl
Move static defaults from params to init
b4093e9 
This makes init easier to read and reduces the risk of forgetting a
default.
@ekohl ekohl merged commit e0f01ce into theforeman:master Dec 2, 2020
@ekohl ekohl deleted the cleanup-params branch December 2, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @ehelms @theforeman-bot