Drop parent_fqdn in favor of deriving from foreman_url #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Dec 16, 2020
ehelms
force-pushed
the
drop-parent-fqdn
branch
from
fb3f3ed to
7cb8ef5
Compare
|
Now with a function for deriving the hostname by parsing the URL. Admittedly, I couldn't come up with a better name than |
ehelms
force-pushed
the
drop-parent-fqdn
branch
from
7cb8ef5 to
c0c2f81
Compare
ekohl
requested changes
Dec 17, 2020
lib/puppet/functions/foreman_proxy_content/hostname_from_url.rb
Outdated
Show resolved
Hide resolved
lib/puppet/functions/foreman_proxy_content/hostname_from_url.rb
Outdated
Show resolved
Hide resolved
ehelms
force-pushed
the
drop-parent-fqdn
branch
from
c0c2f81 to
e8e3fad
Compare
ehelms
force-pushed
the
drop-parent-fqdn
branch
from
e8e3fad to
f98e800
Compare
ekohl
approved these changes
Dec 17, 2020
|
This is backwards incompatible and we will need to handle this in forklift where we pass it in our CI. Do you want to wait for that PR to be ready before we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to continue working toward the number of things a user has to specify to get things working and in this case the number of things a user has to specify multiple times, via different parameters. If we take https://github.com/theforeman/forklift/blob/master/pipelines/install/04-install_proxy.yaml#L11 as an example, the user effectively specifies the Foreman server hostname 4 times in the most basic of commands to install a content proxy.