Ensure foreman_proxy::plugin::pulp does not enable Pulp 2 on EL8 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbclark
reviewed
Jan 28, 2021
| @@ -273,7 +273,7 @@ | |||
| include pulpcore::plugin::certguard # Required to be present by Katello when syncing a content proxy | |||
|
|
|||
| class { 'foreman_proxy::plugin::pulp': | |||
| enabled => !$pulpcore_mirror, | |||
| enabled => !$pulpcore_mirror and $facts['os']['release']['major'] == '7', | |||
There was a problem hiding this comment.
I think this would create an issue for non-RH operating systems. What should the behavior be here for those users?
There was a problem hiding this comment.
This module doesn't support non-RH OSes so it's not really a factor.
There was a problem hiding this comment.
This isn't supported anywhere but EL operating systems so we are good.
ekohl
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.