Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #8175 - configure dispatch router on pulp and pulp nodes #34

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Feb 4, 2015

qpid::router::ssl_profile { 'router-ssl':
ca => $certs::ca_cert,
cert => $certs::params::messaging_client_cert,
key => $certs::params::messaging_client_cert,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid referencing params.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I need some advice here. For the qpid dispatcher, I need 2 ssl profiles on the hub - one for the server and one for the connection to the existing broker.

I'm not really sure what to use, I don't want to create yet more certificates, can I use the qpid-broker ones?

@stbenjam stbenjam force-pushed the 8175 branch 2 times, most recently from 14f8bd6 to 56a59b7 Compare February 13, 2015 09:32
@stbenjam stbenjam force-pushed the 8175 branch 2 times, most recently from d542816 to 04541c1 Compare February 19, 2015 10:23
@stbenjam
Copy link
Member Author

Note, tests will fail until the other PR's mentioned in the top comment.

@stbenjam stbenjam closed this Feb 20, 2015
@stbenjam stbenjam reopened this Feb 20, 2015
@stbenjam stbenjam force-pushed the 8175 branch 2 times, most recently from 7af8a3a to db88289 Compare February 23, 2015 12:48

# SSL Certificate Configuration
class { 'certs::qpid_router':
require => Package[$qpid::router::router_packages],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just require Class['qpid::config'] ? Should that class itself not be requiring this package to be present?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I can't anchor that to happen before because of puppet-concat's voodoo.

Class['qpid::config'] contains the actual file entry for the concat bits, and the certs need to be done before the qdrouterd.conf is laid down.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could require Class['qpid::router::install'], that might be cleaner

@ehelms
Copy link
Member

ehelms commented Feb 23, 2015

ACk

stbenjam added a commit that referenced this pull request Feb 23, 2015
refs #8175 - configure dispatch router on pulp and pulp nodes
@stbenjam stbenjam merged commit 7b366e9 into theforeman:master Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants