Fixes #32567: Ensure bootstrap RPM symlink exists #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a separate existence check for the symlink to ensure it exists and points at the latest RPM. This ensures that if something removes the symlink on the system tne next puppet run will put the symlink back in place. Prior to this the symlink could be removed from the system and the only way Puppet would put it back was if the RPM itself got updated.
ekohl
approved these changes
May 10, 2021
There was a problem hiding this comment.
In the concat module a resource is generated: https://github.com/puppetlabs/puppetlabs-concat/blob/70070beb18b04cd8bd8fb6c9556848bdd0b5f915/lib/puppet/type/concat_file.rb#L323-L354
I wonder if we could do the same thing here.
I'm fine merging this now. Just good to remember that is also a thing if you need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a separate existence check for the symlink to ensure it exists
and points at the latest RPM. This ensures that if something removes
the symlink on the system tne next puppet run will put the symlink
back in place. Prior to this the symlink could be removed from the
system and the only way Puppet would put it back was if the RPM itself
got updated.