fixes #9892 - deploy crane on both pulp and pulp node #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -398,6 +393,13 @@ | |||
| } | |||
| } | |||
|
|
|||
| if $pulp or $pulp_master { | |||
| class { 'crane': | |||
There was a problem hiding this comment.
I think this needs a dependence on Class['certs::apache']
There was a problem hiding this comment.
I suspected it might need a dependence on something, but wasn't sure what. thanks!
There was a problem hiding this comment.
Would it make sense to move this into https://github.com/Katello/puppet-capsule/pull/40/files#diff-60ae41fd0a31977447947f59940ee9a4R259
There was a problem hiding this comment.
I don't think that link points to what you think it links to?
There was a problem hiding this comment.
Heh, it does, sort of. How about -- https://github.com/Katello/puppet-capsule/blob/master/manifests/init.pp#L259
|
@ehelms updated |
|
ACK |
jlsherrill
added a commit
that referenced
this pull request
Apr 7, 2015
fixes #9892 - deploy crane on both pulp and pulp node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.