Fixes #35607 - Pulpcore Telemetry should be disabled initially #431
Conversation
wbclark
force-pushed
the
35607_telemetry
branch
from
a13cb15 to
32394f2
Compare
|
Can we re-run the tests? I am not sure the failure is related..I saw another PR with green tests after this PR.. |
|
@wbclark could you rebase? |
There was a problem hiding this comment.
The puppet-pulpcore PR should have used Refs #35607 and this PR should have used Fixes #35607. The reason is that puppet-pulpcore was a prerequisite to completing the feature, but didn't actually complete it. Now it's marked as completed which means it no longer shows up in my TODOs.
I've now opened the issue again and set a target version. Could you change this PR to use Fixes?
wbclark
force-pushed
the
35607_telemetry
branch
from
32394f2 to
87edfed
Compare
wbclark
changed the title
Thank you. I've rebased, changed the commit message, pushed, and updated the PR title. |
|
The error looks different now. Looks like my ruby brain used a lowercase |
|
Could you also change the pulpcore requirement in metadata.json to at least 7.0.0 (or 7.0.1 when we release a bugfix)? |
|
Opened theforeman/puppet-pulpcore#268 to fix it. Will bump the requirement to 7.0.1 in anticipation of the fix |
Introduces a pulpcore_telemetry parameter which is false by default. Users can opt-in to reporting anonymized telemetry data to the pulp project at https://analytics.pulpproject.org/ by setting the value to true.
wbclark
force-pushed
the
35607_telemetry
branch
from
87edfed to
69cc643
Compare
Introduces a pulpcore_telemetry parameter which is false by default. Users can opt-in to reporting anonymized telemetry data to the pulp project at https://analytics.pulpproject.org/ by setting the value to true.
Requires theforeman/puppet-pulpcore#267