fixes #12000 - add support for remote execution ssh plugin #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only ugly due to formatting change, I'd be OK with this if it means people playing with it in nightlies. I'll let @bbuckingham comment as well since he is handling the change you mention. |
|
Yea the formatting is nasty, but I meant wrapping the plugin in the capsule module itself isn't very nice either |
|
I am Ok with the ugliness to make the functionality available. I am sure it will mean some merge conflicts when the scenario-based changes go in, but that is to be expected. |
|
ACK |
stbenjam
added a commit
that referenced
this pull request
Oct 28, 2015
fixes #12000 - add support for remote execution ssh plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fugly, I don't even know if its worth including and perhaps waiting until foreman-proxy is at the top level.