Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refs #15217 - puppet 4 support #87

Merged
merged 1 commit into from
Jun 22, 2016
Merged

refs #15217 - puppet 4 support #87

merged 1 commit into from
Jun 22, 2016

Conversation

stbenjam
Copy link
Member

No description provided.

@stbenjam stbenjam mentioned this pull request Jun 21, 2016
Merged
10 tasks
@ekohl
Copy link
Member

ekohl commented Jun 21, 2016

It fails because the $::rubyversion fact is not available in the tests. In theforeman we use rspec-puppet-facts to set all the facts and in general I'm pretty happy with that. I'm sure other of your puppet 4 PRs fail on the same problem.

@stbenjam
Copy link
Member Author

Green

@ekohl
Copy link
Member

ekohl commented Jun 22, 2016

ACK

@stbenjam stbenjam merged commit 42ed497 into theforeman:master Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stbenjam @ekohl