No need to configure qpid::client

theforeman · Feb 12, 2021 · 40ababa · 40ababa
1 parent d51f649
commit 40ababa
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 75 deletions.
diff --git a/manifests/application.pp b/manifests/application.pp
@@ -14,12 +14,6 @@
   include certs::pulp_client
   include katello::params
 
-  include certs::qpid
-  include katello::qpid_client
-  User<|title == $foreman::user|>{groups +> 'qpidd'}
-
-  Class['certs', 'certs::ca', 'certs::qpid'] ~> Class['foreman::plugin::tasks']
-
   foreman_config_entry { 'pulp_client_cert':
     value          => $certs::pulp_client::client_cert,
     ignore_missing => false,

diff --git a/manifests/qpid_client.pp b/manifests/qpid_client.pp
diff --git a/spec/classes/application_spec.rb b/spec/classes/application_spec.rb
@@ -27,13 +27,6 @@ class { 'katello::params':
           it { is_expected.to create_package('postgresql-evr') }
         end
 
-        it do
-          is_expected.to contain_class('certs::qpid')
-            .that_notifies(['Class[Foreman::Plugin::Tasks]'])
-        end
-
-        it { is_expected.to contain_class('katello::qpid_client') }
-
         it do
           is_expected.to create_foreman_config_entry('pulp_client_cert')
             .with_value('/etc/pki/katello/certs/pulp-client.crt')

diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb
@@ -8,10 +8,9 @@
       it { is_expected.to compile.with_all_deps }
       it { is_expected.to contain_class('katello::candlepin') }
       it { is_expected.to contain_class('katello::application') }
-      it { is_expected.to contain_class('katello::qpid_client') }
+      it { is_expected.to contain_class('katello::qpid') }
 
       if facts[:operatingsystemmajrelease] == '7'
-        it { is_expected.to contain_class('katello::qpid') }
         it { is_expected.to contain_package('tfm-rubygem-katello').that_requires('Class[candlepin]') }
       else
         it { is_expected.to contain_package('rubygem-katello').that_requires('Class[candlepin]') }

diff --git a/spec/classes/qpid_client_spec.rb b/spec/classes/qpid_client_spec.rb
diff --git a/spec/classes/qpid_spec.rb b/spec/classes/qpid_spec.rb
@@ -5,30 +5,28 @@
     context "on #{os}" do
       let(:facts) { facts }
 
-      if facts[:operatingsystemmajrelease] == '7'
-        context 'with default parameters' do
-          it { is_expected.to compile.with_all_deps }
-          it { is_expected.to contain_class('certs::qpid').that_notifies(['Service[qpidd]', 'Class[qpid]']) }
-          it { is_expected.to create_class('qpid').with_wcache_page_size(4).with_interface('lo') }
-        end
+      context 'with default parameters' do
+        it { is_expected.to compile.with_all_deps }
+        it { is_expected.to contain_class('certs::qpid').that_notifies(['Service[qpidd]', 'Class[qpid]']) }
+        it { is_expected.to create_class('qpid').with_wcache_page_size(4).with_interface('lo') }
+      end
 
-        it do
-          is_expected.to create_qpid__config__queue('katello.agent')
-            .with_ssl_cert('/etc/pki/katello/certs/foo.example.com-qpid-broker.crt')
-            .with_ssl_key('/etc/pki/katello/private/foo.example.com-qpid-broker.key')
-        end
+      it do
+        is_expected.to create_qpid__config__queue('katello.agent')
+          .with_ssl_cert('/etc/pki/katello/certs/foo.example.com-qpid-broker.crt')
+          .with_ssl_key('/etc/pki/katello/private/foo.example.com-qpid-broker.key')
+      end
 
-        context 'with overridden parameters' do
-          let :params do
-            {
-              wcache_page_size: 8,
-            }
-          end
+      context 'with overridden parameters' do
+        let :params do
+          {
+            wcache_page_size: 8,
+          }
+        end
 
-          it 'should pass the variable' do
-            is_expected.to compile.with_all_deps
-            is_expected.to create_class('qpid').with_wcache_page_size(8)
-          end
+        it 'should pass the variable' do
+          is_expected.to compile.with_all_deps
+          is_expected.to create_class('qpid').with_wcache_page_size(8)
         end
       end
     end