Fixes #13658 - pulp_client_key and pulp_client_cert not being set cor… #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems reasonable to me, APJ assuming other PR is good as well (please merge them in tandem) |
| foreman_config_entry { 'pulp_client_cert': | ||
| value => $client_cert, | ||
| ignore_missing => false, | ||
| before => Exec['foreman-rake-db:migrate'], |
There was a problem hiding this comment.
We will want this happen afterward, since this performs a change in the database, we want a migrated database. I might even put this after db:seed just to be safe.
johnpmitsch
force-pushed
the
add_pulp_config
branch
from
420e566 to
f9cdfda
Compare
| foreman_config_entry { 'pulp_client_cert': | ||
| value => $::certs::pulp_client::client_cert, | ||
| ignore_missing => false, | ||
| after => Exec['foreman-rake-db:seed'], |
There was a problem hiding this comment.
We'll need pulp_client to have been run to it come to think of it,
after => [Exec['foreman-rake-db:seed'], Class['::certs::pulp_client']]
There was a problem hiding this comment.
@ehelms thanks updated to use [Exec['foreman-rake-db:seed'], Class['::certs::pulp_client']]
johnpmitsch
force-pushed
the
add_pulp_config
branch
from
f9cdfda to
6135f34
Compare
|
[test] |
| foreman_config_entry { 'pulp_client_cert': | ||
| value => $::certs::pulp_client::client_cert, | ||
| ignore_missing => false, | ||
| after => [Exec['foreman-rake-db:seed'], Class['::certs::pulp_client']], |
There was a problem hiding this comment.
Duh, I told you wrong, these afters should be require
There was a problem hiding this comment.
no worries, I updated to require
johnpmitsch
force-pushed
the
add_pulp_config
branch
from
6135f34 to
4ecc339
Compare
|
ACK - thanks @johnpmitsch ! |
ehelms
added a commit
that referenced
this pull request
Feb 12, 2016
Fixes #13658 - pulp_client_key and pulp_client_cert not being set cor…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rectly
Moved here from puppet-certs theforeman/puppet-certs#75