Optimize tests #159
Merged
Optimize tests #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the difference is negligible since we only support RH7, C7 and SL7 but ONLY_OS is set to RH7 and SL7. |
ehelms
approved these changes
Jan 6, 2017
|
@ekohl did you still want this merged? |
|
@ehelms yes |
This allows us to benefit from ONLY_OS as used in the travis config.
This achieves the same but is slightly easier to read.
|
I rebased this and when the tests are green I intend to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using on_supported_os we can benefit from ONLY_OS thus reducing our test runtime. The use of verify_exact_contents makes it slightly easier to read.