Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GPG key optional #187

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Make GPG key optional #187

merged 1 commit into from
Apr 7, 2017

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 7, 2017

No description provided.

@ehelms
Copy link
Member Author

ehelms commented Apr 7, 2017

Fixes http://ci.theforeman.org/job/release_test_katello_nightly_el7/305/artifact/debug/fb-install-katello.bats.tap/*view*/

stbenjam
stbenjam reviewed Apr 7, 2017
View reviewed changes
manifests/init.pp Outdated
@@ -75,7 +75,7 @@
# type:Boolean
#
# $repo_gpgkey:: The GPG key to use
# type:String
# type:String[Optional]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other way, Optional[String]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, need a kafo linter.

@ehelms
Copy link
Member Author

ehelms commented Apr 7, 2017

Updated

@ehelms ehelms merged commit 7531213 into theforeman:master Apr 7, 2017
@ekohl ekohl mentioned this pull request Apr 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @stbenjam