Refactor module #208
Merged
Refactor module #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially the same code but more concise.
This variable is unsued since 3085e0b.
ekohl
force-pushed
the
split-classes-v4
branch
from
4b9a429 to
938521c
Compare
ekohl
force-pushed
the
split-classes-v4
branch
from
938521c to
fc8a2d1
Compare
This rewrites large parts of the module. The main goal is to split init.pp into several classes that each describe a part of the stack. This is then composed in init.pp where additional chaining is applied. While it doesn't add parameters to choose the composition, it does open the path to it. It also relies more on using puppet-foreman. This means $config_dir is removed in favor of $foreman::plugin_config_dir. Additionally it uses Foreman::rake as chaining rather than the internal Execs. Similarly it now notifies the tasks instead of the Service. All classes use explicit parameters in the local scope and have their own specs.
ekohl
force-pushed
the
split-classes-v4
branch
from
fc8a2d1 to
6476f28
Compare
ehelms
approved these changes
Aug 24, 2017
chris1984
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the major refactoring commits there are 3 cleanup commits.
This rewrites large parts of the module. The main goal is to split init.pp into several classes that each describe a part of the stack. This is then composed in init.pp where additional chaining is applied. While it doesn't add parameters to choose the composition, it does open the path to it.
It also relies more on using puppet-foreman. This means $config_dir is removed in favor of $foreman::plugin_config_dir. Additionally it uses Foreman::rake as chaining rather than the internal Execs. Similarly it now notifies the tasks instead of the Service.
All classes use explicit parameters in the local scope and have their own specs.