Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the candlepin keystore symlink #213

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 8, 2017

This was previously in puppet-certs as /usr/share/tomcat/conf/keystore
but it doesn't belong there. Because /usr/share/tomcat/conf is a symlink
to /etc/tomcat we can safely manage it here as well without duplicating
resources.

Copy link
Member

@sean797 sean797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK Looking at puppet-certs I don't think the ordering matters 👍

@ekohl
Copy link
Member Author

ekohl commented Sep 8, 2017

Currently we rely on the katello meta package to install things but I added the ordering in case we don't.

This was previously in puppet-certs as /usr/share/tomcat/conf/keystore
but it doesn't belong there. Because /usr/share/tomcat/conf is a symlink
to /etc/tomcat we can safely manage it here as well without duplicating
resources.
@ekohl ekohl force-pushed the candlepin-keystore branch from 477402f to 0a7ab23 Compare September 12, 2017 10:57
@ekohl
Copy link
Member Author

ekohl commented Sep 12, 2017

Also made it rely on certs::candlepin. Probably not really needed but better to be sure.

@ekohl ekohl merged commit 4e1371e into theforeman:master Sep 12, 2017
@ekohl ekohl deleted the candlepin-keystore branch September 12, 2017 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants