Refs #22338 - add worker_timeout param #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Jan 22, 2018
manifests/init.pp
Outdated
| @@ -75,6 +75,10 @@ | |||
| # | |||
| # $rest_client_timeout:: Timeout for Katello rest API | |||
| # | |||
| # $pulp_worker_timeout:: The amount of time (in seconds) before considering a worker as missing. If Pulp's | |||
| # mongo database has slow I/O, then setting a higher number may resolve issues where workers are | |||
| # going missing incorrectly. Defaults to 30. | |||
There was a problem hiding this comment.
The default in params.pp is 60. Not sure which we should default to but they should match :)
ekohl
requested changes
Jan 22, 2018
There was a problem hiding this comment.
You don't actually pass the parameter to the pulp class either. Will also need theforeman/puppet-pulp#299
sean797
suggested changes
Jan 22, 2018
manifests/init.pp
Outdated
| @@ -89,6 +93,7 @@ | |||
| String $qpid_interface = $::katello::params::qpid_interface, | |||
| String $qpid_hostname = $::katello::params::qpid_hostname, | |||
| Integer[1] $num_pulp_workers = $::katello::params::num_pulp_workers, | |||
| Integer[0] $pulp_worker_timeout = $katello::params::pulp_worker_timeout, | |||
There was a problem hiding this comment.
Do you mind also properly namespacing this
$::katello::params::pulp_worker_timeout,
|
@ekohl can I get another review please? |
sean797
approved these changes
Jan 23, 2018
ekohl
requested changes
Jan 23, 2018
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@ekohl can you review again when you get a moment please, tests are failing for a different reason. |
|
Looks like we need to pin rdoc in modulesync :( |
ekohl
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.