Set minimum version of puppetlabs/stdlib to 4.25.1 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppetlabs/stdlib 4.6.0 is a non-existant version. This change was introduced in 898eae4 and subsequently the rest of the commit removed in 5de2e01#diff-2f383a197b1a428561b364755701d60e this change is to roll back the minimum required version of stdlib to 4.25.1 I have ran a test against that here: https://travis-ci.org/SeanHood/puppet-katello/jobs/444994576. .fixtures.yml needed to be changed to allow for this, hence missing from this commit. The reason behind this change is that a handful of modules still have a requirement on < 5.0.0. This module doesn't use any of the newly introduced functions in that release.
ekohl
reviewed
Oct 23, 2018
|
I ran some tests to figure out the oldest it will take and it looks to be 4.25.0 (based on current tests) due to the use of Stdlib::Fqdn. You can see this in this failed test here: https://travis-ci.org/SeanHood/puppet-katello/jobs/445105438#L1012 4.25.0 and 4.25.1 both pass, you can see all branches I've tested here: https://travis-ci.org/SeanHood/puppet-katello/branches Edit: I could amend my PR for 4.25.0 or leave it as is. |
ekohl
approved these changes
Oct 23, 2018
ekohl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetlabs/stdlib 4.6.0 is a non-existent version. This change was introduced in 898eae4 and subsequently the rest of the commit removed in 5de2e01. This change is to roll back the minimum required version of stdlib to 4.25.1. I have ran a test against that here: https://travis-ci.org/SeanHood/puppet-katello/jobs/444994576.
.fixtures.ymlneeded to be changed to allow for this, hence missing from this commit.The reason behind this change is that a handful of modules still have a requirement on < 5.0.0. This module doesn't use any of the newly introduced functions in that release.