Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28888 - add cert auth for docker registry #319

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

jlsherrill
Copy link
Contributor

No description provided.

Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @jlsherrill this adds cert auth for the Katello docker registry API. This was done by the forklift playbook previously used by the Katello team and never made it into the puppet modules. Pulp2 Capsule syncs for Docker would go to port 5000 and didn't require cert auth, therefore this only really needs to be present when pulpcore is enabled but isn't hurting anything otherwise.

@jlsherrill
Copy link
Contributor Author

Yep, this /v2/ api is the docker registry that katello provides (that is backed by pulp). These end points need to support cert-based auth in order for a foreman proxy content to be able to sync from it.

Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. My first thought was that this should be conditional on pulpcore and its docker plugin being enabled, but this Katello API will do nothing except in that case so just adding cert auth support for it without making it conditional should be fine.

@jlsherrill
Copy link
Contributor Author

Thanks @wbclark !

@jlsherrill jlsherrill merged commit decf125 into theforeman:master Jan 30, 2020
@jlsherrill jlsherrill deleted the 28888 branch January 30, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants