Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postgresql-evr extension to katello #332

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Add postgresql-evr extension to katello #332

merged 1 commit into from
Apr 20, 2020

Conversation

ianballou
Copy link
Contributor

Adds the postgresql-evr package to katello.

ekohl
ekohl requested changes Apr 9, 2020
View reviewed changes
manifests/application.pp Outdated Show resolved Hide resolved
@ianballou ianballou force-pushed the add-postgresql-evr-package branch from 1b2c40d to 9cdb389 Compare April 9, 2020 15:33
@ianballou ianballou force-pushed the add-postgresql-evr-package branch 3 times, most recently from 60db8d4 to e99ec6f Compare April 9, 2020 16:57
@ianballou
Copy link
Contributor Author

@ekohl I think I've addressed your comments.

@ianballou ianballou mentioned this pull request Apr 9, 2020
Closed
2 tasks
@ianballou ianballou force-pushed the add-postgresql-evr-package branch 2 times, most recently from 200ba9f to d820a34 Compare April 13, 2020 15:56
@ianballou
Copy link
Contributor Author

We have to bump the postgresql-evr version again. I will update the version in this PR once that is up.

@ianballou ianballou force-pushed the add-postgresql-evr-package branch 3 times, most recently from d820a34 to 6ef1c9e Compare April 14, 2020 16:52
jlsherrill
jlsherrill reviewed Apr 16, 2020
View reviewed changes
manifests/params.pp Outdated Show resolved Hide resolved
@ianballou ianballou force-pushed the add-postgresql-evr-package branch from 6ef1c9e to 26dc9d0 Compare April 16, 2020 18:39
@jlsherrill
Copy link
Contributor

@ianballou do those failures make any sense to you?

@ianballou
Copy link
Contributor Author

ianballou commented Apr 16, 2020 •
edited
Loading

@jlsherrill they don't, I'm going to test again locally.

Edit: it appears it was due to a linting issue. Fixed now.

@ianballou ianballou force-pushed the add-postgresql-evr-package branch from 26dc9d0 to c300cc0 Compare April 16, 2020 19:02
@ianballou
Copy link
Contributor Author

ianballou commented Apr 16, 2020 •
edited
Loading

I'm not sure why those warnings are still there, I'm not hitting that locally.

Edit: I am hitting these locally now after updating. It doesn't appear to be related to my PR.

@ianballou ianballou force-pushed the add-postgresql-evr-package branch from c300cc0 to 1d19f92 Compare April 16, 2020 19:42
ekohl
ekohl requested changes Apr 16, 2020
View reviewed changes
manifests/application.pp Outdated Show resolved Hide resolved
manifests/application.pp Outdated Show resolved Hide resolved
manifests/params.pp Outdated Show resolved Hide resolved
manifests/application.pp Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Apr 16, 2020

6f42d22 was merged but had a bug and didn't actually ran the tests. That was fixed in a voxpupuli-tests 1.2 release, but I'm going through the modules to correct it, but that takes a bit of time.

@ianballou ianballou force-pushed the add-postgresql-evr-package branch from 1d19f92 to 804f1b9 Compare April 16, 2020 21:44
@ianballou ianballou force-pushed the add-postgresql-evr-package branch from 804f1b9 to 46bc490 Compare April 16, 2020 21:46
@ianballou
Copy link
Contributor Author

@ekohl thanks for the review, I've pushed the changes. Just waiting now to test them out.

@jlsherrill
Copy link
Contributor

this still isn't running, @ianballou maybe it needs a rebase?

ehelms
ehelms reviewed Apr 19, 2020
View reviewed changes
manifests/application.pp Outdated Show resolved Hide resolved
@ianballou ianballou force-pushed the add-postgresql-evr-package branch from 46bc490 to 6cb3503 Compare April 20, 2020 13:37
@ianballou ianballou force-pushed the add-postgresql-evr-package branch from 6cb3503 to 412c9e9 Compare April 20, 2020 13:41
@ianballou
Copy link
Contributor Author

Tests are passing now, is the PR looking all set?

@ehelms ehelms merged commit 3c6fc2c into theforeman:master Apr 20, 2020
@ianballou ianballou deleted the add-postgresql-evr-package branch April 21, 2020 16:17
@m-bucher m-bucher mentioned this pull request May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlsherrill jlsherrill jlsherrill left review comments

@ekohl ekohl ekohl requested changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ianballou @jlsherrill @ekohl @ehelms @theforeman-bot @wbclark