-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #29664: Update Candlepin port to new default #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in theforeman/puppet-candlepin#156 (review), I think this commit should be Fixes
.
I'd like to get #339 in before this |
From my testing, this will require SELinux changes. @lzap can you help with that when you have time? I imagine they would be in the katello-selinux policy. |
Tested full install piepline with the SELinux change here -- theforeman/katello-selinux#26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's now a conflict. I also think this should be Fixes #29664
The commit was already fixes but I updated the MR title to reflect the same. This is waiting on final review of theforeman/katello-selinux#29 |
Are we OK with merging and making this change now? |
I'm labeling this as backwards incompatible because I think this deserves a major version bump. I don't want to risk accidentally cherry picking a minor version in a stable release. |
Does not "require" theforeman/puppet-candlepin#156 but I would like them to be in sync default wise and resolve the port number conversation.