Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #29664: Update Candlepin port to new default #348

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jun 5, 2020

Does not "require" theforeman/puppet-candlepin#156 but I would like them to be in sync default wise and resolve the port number conversation.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in theforeman/puppet-candlepin#156 (review), I think this commit should be Fixes.

@ekohl
Copy link
Member

ekohl commented Jun 5, 2020

I'd like to get #339 in before this

@ehelms
Copy link
Member Author

ehelms commented Jun 9, 2020

From my testing, this will require SELinux changes. @lzap can you help with that when you have time? I imagine they would be in the katello-selinux policy.

@ehelms
Copy link
Member Author

ehelms commented Jul 15, 2020

Tested full install piepline with the SELinux change here -- theforeman/katello-selinux#26

[root@pipeline-katello-server-nightly-centos7 vagrant]# netstat -nlp | grep 23443
tcp6       0      0 127.0.0.1:23443         :::*                    LISTEN      26510/java          
[root@pipeline-katello-server-nightly-centos7 vagrant]# netstat -nlp | grep 8443

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now a conflict. I also think this should be Fixes #29664

@ehelms ehelms changed the title Refs #29664: Update Candlepin port to new default Fixes #29664: Update Candlepin port to new default Jul 31, 2020
@ehelms
Copy link
Member Author

ehelms commented Jul 31, 2020

The commit was already fixes but I updated the MR title to reflect the same. This is waiting on final review of theforeman/katello-selinux#29

@ehelms
Copy link
Member Author

ehelms commented Aug 31, 2020

Are we OK with merging and making this change now?

@ekohl
Copy link
Member

ekohl commented Aug 31, 2020

I'm labeling this as backwards incompatible because I think this deserves a major version bump. I don't want to risk accidentally cherry picking a minor version in a stable release.

@ekohl ekohl merged commit 7200bf3 into theforeman:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants