Use Foreman client certificates to setup qpid queues #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbclark
reviewed
Jul 30, 2021
ehelms
force-pushed
the
use-foreman-client-certs-qpid
branch
from
aeff98f to
ad3a7ca
Compare
wbclark
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
LGTM.
Please add a Redmine to the tracker at https://projects.theforeman.org/issues/32381 and update the commit message here to include the issue # if you would please before merging.
Katello uses the Foreman client certificates to talk to Qpid when katello-agent support is enabled, the same should be used when setting up Qpid queues and exchanges and not the server certificates that are intended to be used by Qpid itself.
ehelms
force-pushed
the
use-foreman-client-certs-qpid
branch
from
ad3a7ca to
09ecd36
Compare
|
Previous run was green, failing due to nightlies needing to pass and push with 3.0/3.1 changes in packaging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Katello uses the Foreman client certificates to talk to Qpid when
katello-agent support is enabled, the same should be used when
setting up Qpid queues and exchanges and not the server certificates
that are intended to be used by Qpid itself.