Move all OS-dependent config to params.pp #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 Just needs a rebase |
ekohl
force-pushed
the
reuse-parameters
branch
from
3f2c24b to
f3afc31
Compare
|
Rebased |
|
@ekohl looks like this needs another rebase, sorry for missing it earlier |
ekohl
force-pushed
the
reuse-parameters
branch
from
f3afc31 to
2a85f54
Compare
|
@ehelms rebased |
|
@ekohl looks like a bad coincidence, the PR that was just merged broke you again :/ |
This also treats the entire RedHat osfamily (except Fedora) as EL.
ekohl
force-pushed
the
reuse-parameters
branch
from
2a85f54 to
fb93e28
Compare
|
@ehelms so how about now :) |
|
LGTM, thanks @ekohl ! |
ehelms
added a commit
that referenced
this pull request
Nov 12, 2014
Move all OS-dependent config to params.pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also treats the entire RedHat osfamily (except Fedora) as EL.