Fixes #7802 - ensures qpidd group present before adding user to group #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustints
force-pushed
the
7802_user_qpidd_group
branch
from
f7b1608 to
026ffa6
Compare
| @@ -4,10 +4,12 @@ | |||
| $client_key = undef, | |||
| $katello_user = undef | |||
| ){ | |||
| include qpid | |||
There was a problem hiding this comment.
@ehelms it was failing the katello_spec test without it...complained that Group[qpid] was not defined in the test.
There was a problem hiding this comment.
maybe there is a way to include it only in the test.
There was a problem hiding this comment.
Oh, right - that makes sense. If including qpid, I think you could change the below to:
Group[qpid::group] ->
There was a problem hiding this comment.
@ehelms couldn't get Group[qpid::group] working
wasn't able to get around this error message: "Could not find resource 'Group[undef]' for relationship from 'Class[Katello]' on node"
dustints
force-pushed
the
7802_user_qpidd_group
branch
from
026ffa6 to
53ca553
Compare
|
[test] |
1 similar comment
|
[test] |
dustints
force-pushed
the
7802_user_qpidd_group
branch
from
7122b1f to
67c3c06
Compare
dustints
force-pushed
the
7802_user_qpidd_group
branch
from
67c3c06 to
3021285
Compare
|
ACK |
dustints
pushed a commit
that referenced
this pull request
Oct 24, 2014
Fixes #7802 - ensures qpidd group present before adding user to group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related pull-requests that fixes #7802
#45
theforeman/puppet-katello_devel#26
theforeman/puppet-qpid#11