Ref #8548 - optionally configure gutterball #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dustints is there a use case for not installing gutterball with Katello? |
|
@ehelms, after talking with @thomasmckay it would nice to give the user the ability to optionally include/exclude gutterball. Right now I have gutterball set to by default false...going to switch it to true. |
|
@ehelms rebased and updated, making gutterball installation true by default |
|
waiting for puppet-certs update before this will pass travis-ci |
|
[test] |
dustints
pushed a commit
to dustints/katello-installer
that referenced
this pull request
Dec 15, 2014
|
ACK |
| @@ -112,5 +116,14 @@ | |||
|
|
|||
| Service['httpd'] -> Exec['foreman-rake-db:seed'] | |||
|
|
|||
| if $katello::gutterball { | |||
| notify{ 'gutterball enabled': } | |||
There was a problem hiding this comment.
Others don't notify and this will always show up in the logs of the user. I'd remove this.
|
@ekohl updated |
|
ACK pending @ekohl |
dustints
pushed a commit
to dustints/katello-installer
that referenced
this pull request
Dec 15, 2014
* add gutterball module * latest certs module * katello module changes not yet offical until theforeman/puppet-katello#52
|
👍 |
thomasmckay
pushed a commit
that referenced
this pull request
Dec 16, 2014
Ref #8548 - optionally configure gutterball
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.