Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs 9207 #64

Merged
merged 1 commit into from
May 14, 2015
Merged

Refs 9207 #64

merged 1 commit into from
May 14, 2015

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Feb 28, 2015

No description provided.

stbenjam
stbenjam reviewed Feb 28, 2015
View reviewed changes
CHANGELOG
@@ -1 +1,5 @@
2014-07-27 Release 0.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename this to .md if it'll be in markdown

@ekohl
Copy link
Member

ekohl commented Feb 28, 2015

You can also drop foreman_oauth_key from params.pp. I'd also simplify the comment above it because I think it's no longer relevant.

@ehelms
Copy link
Member Author

ehelms commented Mar 2, 2015

@stbenjam could you look at #50 as I'd like to get that in before this.

@ekohl ekohl mentioned this pull request Mar 2, 2015
Merged
@ekohl
Copy link
Member

ekohl commented Apr 22, 2015

@ehelms I think this needs a rebase.

@ehelms
Copy link
Member Author

ehelms commented Apr 22, 2015

@ekohl Will do. I was thinking of doing the modulesync part first, and then re-basing and revisiting this.

@ehelms
Copy link
Member Author

ehelms commented May 14, 2015

@ekohl @stbenjam Updated and rebased this post modulesync updates.

@stbenjam
Copy link
Member

ACK

ehelms added a commit that referenced this pull request May 14, 2015
@ehelms
Merge pull request #64 from ehelms/refs-9207
4a6177e 
Refs 9207
@ehelms ehelms merged commit 4a6177e into theforeman:master May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @ekohl @stbenjam