Adding support for Scientific Linux #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks good, but I can't tell if the test failures are caused by this or something unrelated. |
|
Local testing, this appears to be failing because its not getting the apache_version properly. I am still trying to figure out how to get it to grab it properly. |
ehelms
force-pushed
the
support-sci-linux
branch
from
5092a43 to
b127501
Compare
|
Updated. I was calling the version class and not referencing the variable itself. |
|
👍 |
|
@stbenjam mind taking a peek as well? |
|
Looks good to me ACK |
ehelms
added a commit
that referenced
this pull request
Apr 22, 2015
Adding support for Scientific Linux
ehelms
added a commit
to ehelms/puppet-katello
that referenced
this pull request
Apr 23, 2015
Adding support for Scientific Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.