Fixes #11609: Update to use Pulp module 1.0 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| messaging_ca_cert => $certs::pulp_parent::messaging_ca_cert, | ||
| messaging_client_cert => $certs::pulp_parent::messaging_client_cert, | ||
| consumers_ca_cert => $certs::ca_cert, | ||
| consumers_ca_key => $certs::ca_key, | ||
| consumers_crl => $candlepin::crl_file, | ||
| proxy_url => $proxy_url, | ||
| proxy_port => $proxy_port, | ||
| proxy_username => $proxy_username, | ||
| proxy_password => $proxy_password, |
There was a problem hiding this comment.
The =>'s should be aligned one space to the right of the longest parameter
|
Is 1.0 ready? |
|
I believe so functional parity wise - I wanted to do this part and do a test round with the installer, however, that is hard to do right now in the middle of TFM migration. This PR does remove an input parameter from this module. |
ehelms
force-pushed
the
fixes-11609
branch
2 times, most recently
from
0a22003 to
8ea7c81
Compare
|
@stbenjam pushed updates to what we need to pass to Pulp and deploy, my local testing says this should be good to go along with -- theforeman/puppet-pulp#97 |
|
ACK |
ehelms
added a commit
that referenced
this pull request
Sep 8, 2015
Fixes #11609: Update to use Pulp module 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.