Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README #242

Merged
merged 2 commits into from
Jul 18, 2017
Merged

Update the README #242

merged 2 commits into from
Jul 18, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented May 21, 2017

Still not very good, but an improvement aimed to address #143 and #241.

@rammaram06 @rgarrigue @djjudas21 if you could have a look then that'd great.

@ram-devsecops
Copy link

@ekohl this looks good..would you be able to add an example on how to setup ssl configuration?

@ekohl
Copy link
Member Author

ekohl commented May 21, 2017

I've added some SSL examples, but haven't tested it yet. Looks like I'm still missing some of the settings on the messaging.

@djjudas21
Copy link

This looks much more useful. I'll try it out properly tomorrow - thanks!

@rgarrigue
Copy link

rgarrigue commented May 23, 2017 via email

@ekohl
Copy link
Member Author

ekohl commented May 30, 2017

I'm trying to simplify the usage of the admin in #248. Once that's in I'm going to expand the README.

@ekohl ekohl mentioned this pull request Jul 12, 2017
@ekohl
Copy link
Member Author

ekohl commented Jul 12, 2017

Updated.

  • There's a debug parameter, document it and explain where's the output if it's a specific file (as opposed to puppet output)

I'm not sure what these exactly do so I've left them out for now.

  • Add a quick exemple to open firewall port with crayshfix's firewalld module, since it's all about centos 7

Personally I've always used the puppetlabs-firewall module so I'm leaving this out for now. I could mention the ports used.

That's it for what I'm doing. Reading the params.pp, an example with a proxy configuration might interest people too

I noticed we have the parameter proxy_url which maps to proxy_host in the config. @ehelms you added this in 6388c09 so can you have a look?

@ehelms
Copy link
Member

ehelms commented Jul 13, 2017

@ekohl guessing it was a bit of a typo when configuring this for use with Katello's installer

@ekohl
Copy link
Member Author

ekohl commented Jul 13, 2017

Given we're going to do a major version, shall we change it to proxy_host?

@ekohl
Copy link
Member Author

ekohl commented Jul 16, 2017

I'd like to get his merged on Tuesday because even if this is still incomplete, I think it's better than what we have now. Please point out any mistakes though. Suggestions for additions are also welcome and will be addressed in a separate PR.

@ekohl ekohl merged commit 19f9a36 into theforeman:master Jul 18, 2017
@ekohl ekohl deleted the docs branch July 18, 2017 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants