Skip to content

Commit

Permalink
Support Puppet 7
Browse files Browse the repository at this point in the history
Forcing the locale in acceptance tests isn't pretty but for now it's a
valid workaround. Note that the candlepin DB is already forced to
en_US.UTF-8 but this affects initdb. We may see similar problems in
production, but in general LANG should be matching a system locale.
  • Loading branch information
ekohl committed May 31, 2021
1 parent 1692fcb commit e19f1e7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,6 @@ jobs:
env:
BEAKER_PUPPET_COLLECTION: ${{ matrix.puppet.collection }}
BEAKER_setfile: ${{ matrix.setfile.value }}
# In Puppet 7 the locale ends up being C.UTF-8 if it isn't passed.
# This locale doesn't exist in EL7 and won't be supported either.
LANG: en_US.UTF-8
2 changes: 1 addition & 1 deletion metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"requirements": [
{
"name": "puppet",
"version_requirement": ">= 5.5.8 < 7.0.0"
"version_requirement": ">= 5.5.8 < 8.0.0"
}
]
}

0 comments on commit e19f1e7

Please sign in to comment.