Manage the static assets via a class #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't verify this - it's true for "standard" Django, but with whitenoise this may not be true. |
|
Note I extracted this from #115, which is why I assumed it was already done. |
wbclark
reviewed
Sep 14, 2020
manifests/static.pp
Outdated
| # @summary Manage the static files (assets) | ||
| # @api private | ||
| class pulpcore::static { | ||
| file { $pulpcore::static_root: |
There was a problem hiding this comment.
I think this parameter $pulpcore::static_root was present in your other PR but didn't get included here, which is breaking things
Otherwise it looks good to me
There was a problem hiding this comment.
Ah yes, here it was still pulp_static_root.
Since 8c66bff the pulpcore-manager command runs as root. On a fresh installation this is fine, but on upgrades the user doesn't own /var/lib/pulp/assets. This explicitly manages the static root. It is split off to a separate class to better capture the dependencies. The database doesn't need to refresh due to static files, nor any services.
By setting it in settings.py, pulp-manager will also know about it. It also makes the service file more straight forward.
|
I added a commit that sets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8c66bff the pulpcore-manager command runs as root. On a fresh installation this is fine, but on upgrades the user doesn't own /var/lib/pulp/assets. This explicitly manages the static root.
It is split off to a separate class to better capture the dependencies. The database doesn't need to refresh due to static files, nor any services.