-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pulpcore repository class #123
Conversation
@evgeni this probably interests you. I do wonder if we should have some first stage where we test a reduced matrix and then a second stage where we test the rest. For example, 3.7 on Puppet 6 (probably both EL7 and EL8) and then all other variations on it. |
Do you mean interests me to test/stage pulpcore, or puppet-pulpcore? |
Also note that currently it doesn't appear to work yet and it doesn't find the custom fact, hence the draft status. |
I mostly hope to get some help on the Github actions part but also verification of the RPM packages in the repo. |
Note to self: testing with 3.6 shows
|
Ok, the conclusion is that the 3.7 repo is not installable yet but the mechanism works with 3.4 and 3.6. Caching of gems works well, about 10 seconds on a cache hit is nice. |
Updated. I dropped the multi version testing for later and also pointed the repo to 3.6 instead of 3.7 (which isn't done yet). |
Tests should now also pass. |
ensure => file, | ||
content => $pulpcore_repo_conf, | ||
class { 'pulpcore::repo': | ||
version => fact('pulpcore_version'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once voxpupuli/voxpupuli-acceptance#13 is merged and released in the gem, you can use BEAKER_FACTER_PULPCORE_VERSION=3.7
when running beaker to test out version 3.7. If it's undefined, it falls back to the class default (3.6).
This class uses the new yum.theforeman.org repos that are versions per Pulpcore release. This allows easy switching between versions. It also properly sets the GPG key validation. It does switch acceptance testing from staging repositories to stable repositories. Another implication is that it switches to Pulpcore 3.6 by default. This was chosen since 3.7 is not complete yet.
This class uses the new yum.theforeman.org repos that are versions per Pulpcore release. This allows easy switching between versions. It also properly sets the GPG key validation.
It does switch acceptance testing from staging repositories to stable repositories. Another implication is that it switches to Pulpcore 3.6 by default. This was chosen since 3.7 is not complete yet.