Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pulpcore repository class #123

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 30, 2020

This class uses the new yum.theforeman.org repos that are versions per Pulpcore release. This allows easy switching between versions. It also properly sets the GPG key validation.

It does switch acceptance testing from staging repositories to stable repositories. Another implication is that it switches to Pulpcore 3.6 by default. This was chosen since 3.7 is not complete yet.

manifests/repo.pp Outdated Show resolved Hide resolved
@ekohl
Copy link
Member Author

ekohl commented Sep 30, 2020

@evgeni this probably interests you. I do wonder if we should have some first stage where we test a reduced matrix and then a second stage where we test the rest. For example, 3.7 on Puppet 6 (probably both EL7 and EL8) and then all other variations on it.

@ekohl ekohl marked this pull request as draft September 30, 2020 16:51
@evgeni
Copy link
Member

evgeni commented Sep 30, 2020

Do you mean interests me to test/stage pulpcore, or puppet-pulpcore?

@ekohl
Copy link
Member Author

ekohl commented Sep 30, 2020

Also note that currently it doesn't appear to work yet and it doesn't find the custom fact, hence the draft status.

@ekohl
Copy link
Member Author

ekohl commented Sep 30, 2020

Do you mean interests me to test/stage pulpcore, or puppet-pulpcore?

I mostly hope to get some help on the Github actions part but also verification of the RPM packages in the repo.

@ekohl
Copy link
Member Author

ekohl commented Sep 30, 2020

Note to self: testing with 3.6 shows

System check identified some issues:
  
  WARNINGS:
  ?: (guardian.W001) Guardian authentication backend is not hooked. You can add this in settings as eg: `AUTHENTICATION_BACKENDS = ('django.contrib.auth.backends.ModelBackend', 'guardian.backends.ObjectPermissionBackend')`.

@ekohl
Copy link
Member Author

ekohl commented Sep 30, 2020

Ok, the conclusion is that the 3.7 repo is not installable yet but the mechanism works with 3.4 and 3.6. Caching of gems works well, about 10 seconds on a cache hit is nice.

@ekohl
Copy link
Member Author

ekohl commented Oct 6, 2020

Updated. I dropped the multi version testing for later and also pointed the repo to 3.6 instead of 3.7 (which isn't done yet).

@ekohl
Copy link
Member Author

ekohl commented Oct 6, 2020

Tests should now also pass.

ensure => file,
content => $pulpcore_repo_conf,
class { 'pulpcore::repo':
version => fact('pulpcore_version'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once voxpupuli/voxpupuli-acceptance#13 is merged and released in the gem, you can use BEAKER_FACTER_PULPCORE_VERSION=3.7 when running beaker to test out version 3.7. If it's undefined, it falls back to the class default (3.6).

templates/repo.epp Outdated Show resolved Hide resolved
manifests/repo.pp Outdated Show resolved Hide resolved
templates/repo.epp Outdated Show resolved Hide resolved
This class uses the new yum.theforeman.org repos that are versions per
Pulpcore release. This allows easy switching between versions. It also
properly sets the GPG key validation.

It does switch acceptance testing from staging repositories to stable
repositories. Another implication is that it switches to Pulpcore 3.6 by
default. This was chosen since 3.7 is not complete yet.
@ehelms ehelms merged commit c9a96d8 into theforeman:master Oct 6, 2020
@ekohl ekohl deleted the repo-class branch October 6, 2020 19:17
@ekohl ekohl added the Enhancement New feature or request label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants