Fixes #32309 - pulpcore-manager fails from certain directories

[ianballou]

Sets a specific directory for pulpcore-manager to be called from.

[ekohl]

The change itself makes sense to me. However, please make the commit message more descriptive. Like Always run admin cmds from Pulp's home (not sure how much will fit). Ideally with then a body that describes that the cwd might be an unreadable directory like /root and dynaconf appears to unconditionally read the current directory. Pulp's user home should always be readable for the user pulp.

Also, it might be good to link to a dynaconf bugreport. IMHO it shouldn't error out on unreadable CWD.

[ekohl]

I prefer to be stricter, even if it doesn't really make a difference.

Suggested change

	String $working_dir = $pulpcore::user_home,
	Stdlib::Absolutepath $working_dir = $pulpcore::user_home,

[ianballou]

Not sure yet why the tests are complaining about Unknown variable: 'pulpcore::user_home'.

[ekohl]

In that testcase we don't include the class pulpcore so it can't reference the variable. That's why we explicitly set those in the tests:

puppet-pulpcore/spec/defines/admin_spec.rb

Lines 9 to 15 in 9f680a1

	context 'with a fixed pulp_settings and user' do
	let(:params) do
	{
	pulp_settings: '/etc/pulpcore/settings.py',
	user: 'pulpcore',
	}
	end

[ianballou]

@ekohl I think we're all good now.

[wbclark]

Hey @ianballou , could you please add to the test below, under is_expected.to contain_exec('pulpcore-manager help'),

.with_cwd('/var/lib/pulp')

This way we are not only passing the param from the parent module which pulpcore::admin needs, we are also testing that the feature works properly at the business logic level (puppet catalogue) and continues working as expected with any future changes.

[ianballou]

@wbclark okay, I added the test condition.

[wbclark]

@wbclark okay, I added the test condition.

Great, thank you. This looks good to me. Let's see what @ekohl says

[ekohl]

This is what I would have written as well

[goosemania]

The change itself makes sense to me. However, please make the commit message more descriptive. Like Always run admin cmds from Pulp's home (not sure how much will fit). Ideally with then a body that describes that the cwd might be an unreadable directory like /root and dynaconf appears to unconditionally read the current directory. Pulp's user home should always be readable for the user pulp.

Also, it might be good to link to a dynaconf bugreport. IMHO it shouldn't error out on unreadable CWD.

FWIW, tried to fix, this helped https://github.com/rochacbruno/dynaconf/pull/570