Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pulp 3.13, drop earlier versions #202

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jun 17, 2021

Pulp 3.13 moves to a new wrapper for the worker. This isn't present in older releases so support for them is dropped.

Pulp 3.13 moves to a new wrapper for the worker. This isn't present in
older releases so support for them is dropped.
@ekohl
Copy link
Member Author

ekohl commented Jun 17, 2021

Needs 3.13 to show up on the mirrors. I'm sure @evgeni is working on this now.

@evgeni
Copy link
Member

evgeni commented Jun 17, 2021

Which just happened. I re-triggered the jobs.

@ekohl
Copy link
Member Author

ekohl commented Jun 17, 2021

To be clear, we should do a minor release before we bump to a major.

@evgeni
Copy link
Member

evgeni commented Jun 17, 2021

ah, and there is no compatoble 2to3 migration for 3.13 yet.

given it's not used by katello anymore, shall we drop it?

@ekohl
Copy link
Member Author

ekohl commented Jun 17, 2021

Won't that break upgrades for users? Recently we had a chat with Tanya on IRC and she said it's being worked on.

@ehelms
Copy link
Member

ehelms commented Jun 17, 2021

Does 3.13 drop the RQ worker? Or are both provided as options?

@ekohl
Copy link
Member Author

ekohl commented Jun 17, 2021

I think the worker script is a wrapper that can call both, depending on the settings. Technically we can introduce a simple shell wrappper in pulpcore 3.11 RPM to remain compatible, but I'm not sure we should take that route.

@evgeni
Copy link
Member

evgeni commented Jun 17, 2021

Yeah, I think RQ is still the default, but you can make it use something else.

@ehelms
Copy link
Member

ehelms commented Jun 24, 2021

Do these new workers require any updates to Pulp's selinux policy?

@ekohl
Copy link
Member Author

ekohl commented Jun 24, 2021

I don't think they do since this covers both the old and new wrapper.
https://github.com/pulp/pulpcore-selinux/blob/064442e829310e6bab95aa639343a8cfaf90f219/pulpcore.fc#L11

@evgeni
Copy link
Member

evgeni commented Jun 25, 2021

That's my understanding as well.

I've opened theforeman/pulpcore-packaging#180 to get in the new 2to3 migration plugin, which is compatible with 3.13 in, which should make the tests happy.

@ekohl
Copy link
Member Author

ekohl commented Jun 28, 2021

This is now green.

@ehelms ehelms merged commit 137128e into theforeman:master Jun 29, 2021
@ekohl ekohl deleted the pulp-3.13 branch July 5, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants