Contain Redis within database #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I think this is a good change, I don't think it will fix the issue. The error I've been seeing is after the installer has finished (and I'd expect at that point Redis to run, regardless of ordering in Puppet). The interesting thing is: I've not seen a redis service unit in the sosreport of the proxy at all :( |
You're right: this can fix issues but not the one we're running into. |
Without this, the Redis class may not be complete. That means Redis doesn't have to be running by the time the services are started.
ehelms
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the Redis class may not be complete. That means Redis doesn't have to be running by the time the services are started.