Fixes #33446 - Allow configuring Pulpcore worker timeout #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2021
wbclark
force-pushed
the
33446-with-original-test-style
branch
from
eff37b8 to
826b3e7
Compare
ekohl
reviewed
Oct 1, 2021
This change implements the WORKER_TTL setting which lets Pulp decide how long to wait for a worker to respond before considering it gone and cleaning up it's database and re-assiging work.
wbclark
force-pushed
the
33446-with-original-test-style
branch
from
826b3e7 to
bffd1bd
Compare
wbclark
force-pushed
the
33446-with-original-test-style
branch
from
bffd1bd to
3679d54
Compare
|
force pushing to trigger CI |
ekohl
requested changes
Oct 5, 2021
wbclark
force-pushed
the
33446-with-original-test-style
branch
from
3679d54 to
3273438
Compare
|
@ekohl thank you for the feedback, I updated with the requested changes. While the tests passed for me locally, for some reason CI has not run on my recent pushes. Any idea why that is? |
|
When I opened issues I saw:
That's kind of weird. I guess they optimize the cronjobs on idle repos (which probably makes sense) but for us it's also the PR testing. I've enabled it now, but I'll take it up with GH. |
|
@ekohl thanks! any other feedback on this PR or do you think we are good to go? |
ekohl
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.