use provides, not the python package name for plugins #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
evgeni
commented
Oct 19, 2021
•
evgeni
commented
evgeni
commented
Oct 19, 2021
| @@ -3,10 +3,6 @@ | |||
| # @api private | |||
| class pulpcore::install { | |||
|
|
|||
| package { 'python3-pulpcore': | |||
There was a problem hiding this comment.
@ekohl or should this "Provides: pulpcore"?
There was a problem hiding this comment.
I think you still want to explicitly install the package in case there is no plugin. I'd be happy with a Provides: pulpcore and then install pulpcore.
There was a problem hiding this comment.
If there is no plugin, pulpcore won't start up 🤷♀️
There was a problem hiding this comment.
I backed these out for now, as tests fail without 🤷♀️
|
currently failing because the provides aren't published yet, I'll re-kick once that happened |
evgeni
force-pushed
the
provides
branch
2 times, most recently
from
a818695 to
b9baaf0
Compare
ekohl
reviewed
Oct 20, 2021
There was a problem hiding this comment.
I wonder if we should mention this in https://github.com/theforeman/puppet-pulpcore#pulpcore-314. Other than that 👍
ekohl
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.